Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove NVTX calls in libcugraph_etl #4229

Merged
merged 1 commit into from
Mar 11, 2024
Merged

remove NVTX calls in libcugraph_etl #4229

merged 1 commit into from
Mar 11, 2024

Conversation

ChuckHastings
Copy link
Collaborator

NVTX calls are not necessary for this prototype capability.

@ChuckHastings ChuckHastings self-assigned this Mar 10, 2024
@ChuckHastings ChuckHastings added non-breaking Non-breaking change CRITICAL BUG! BUG that needs to be FIX NOW !!!! and removed cuGraph labels Mar 10, 2024
@ChuckHastings ChuckHastings marked this pull request as ready for review March 10, 2024 16:41
@ChuckHastings ChuckHastings requested a review from a team as a code owner March 10, 2024 16:41
naimnv
naimnv approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@naimnv naimnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bdice
bdice approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work as long as none of the other cudf detail headers being included have any NVTX references. If this passes CI, it should be good to merge.

@bdice bdice added the bug Something isn't working label Mar 10, 2024
seunghwak
seunghwak approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for the quick fix!!!

@ChuckHastings
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit e0d18c9 into rapidsai:branch-24.04 Mar 11, 2024
136 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naimnv naimnv naimnv approved these changes

@bdice bdice bdice approved these changes

@seunghwak seunghwak seunghwak approved these changes

Assignees

@ChuckHastings ChuckHastings

Labels
bug Something isn't working CRITICAL BUG! BUG that needs to be FIX NOW !!!! non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChuckHastings @bdice @seunghwak @naimnv