Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTMG gather use of streams #4237

Merged
merged 2 commits into from
Mar 13, 2024
Merged

MTMG gather use of streams #4237

merged 2 commits into from
Mar 13, 2024

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Mar 13, 2024 •
edited
Loading

mtmg::vertex_result_t::gather was causing intermittent flaky results.

A couple of issues were identified:

  • Stream use was incorrect. We were using a stream from the stream pool AND the default stream. Modified to use the default stream throughout to resolve the issue. Created MTMG Use of streams #4236 to design a long-term solution.
  • Customer use case was trying to gather results from vertices that didn't exist. Added a mechanism to allow for that and return a default value for vertices that don't exist.

Closes https://github.com/rapidsai/graph_dl/issues/464

@ChuckHastings ChuckHastings self-assigned this Mar 13, 2024
@ChuckHastings ChuckHastings modified the milestones: 23.06, 24.04 Mar 13, 2024
@ChuckHastings ChuckHastings added non-breaking Non-breaking change CRITICAL BUG! BUG that needs to be FIX NOW !!!! labels Mar 13, 2024
@ChuckHastings ChuckHastings marked this pull request as ready for review March 13, 2024 16:05
@ChuckHastings ChuckHastings requested a review from a team as a code owner March 13, 2024 16:05
@ChuckHastings ChuckHastings added the bug Something isn't working label Mar 13, 2024
seunghwak
seunghwak reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

naimnv
naimnv approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@naimnv naimnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Quite a bit of bookkeeping to get things right :)

@ChuckHastings
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit 0981a8d into rapidsai:branch-24.04 Mar 13, 2024
137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naimnv naimnv naimnv approved these changes

@seunghwak seunghwak seunghwak approved these changes

@jnke2016 jnke2016 Awaiting requested review from jnke2016

Assignees

@ChuckHastings ChuckHastings

Labels
bug Something isn't working CRITICAL BUG! BUG that needs to be FIX NOW !!!! cuGraph non-breaking Non-breaking change
Projects
None yet
Milestone
24.04
Development

Successfully merging this pull request may close these issues.
3 participants
@ChuckHastings @seunghwak @naimnv