Fix stream synchronization in MTMG graph construction #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
improvement
seunghwak
approved these changes
May 21, 2024
| * @param device_buffer_size Number of edges to store in each device buffer | ||
| * @param use_weight Whether or not the edgelist will have weights | ||
| * @param use_edge_id Whether or not the edgelist will have edge ids | ||
| * @param use_edge_type Whether or not the edgelist will have edge types | ||
| */ | ||
| per_device_edgelist_t(cugraph::mtmg::handle_t const& handle, | ||
| per_device_edgelist_t(rmm::cuda_stream_view stream_view, |
There was a problem hiding this comment.
Something tedious, but I guess our convention is to pass the handle as the first input argument and stream_view as the last input argument. Should we better keep this convention?
There was a problem hiding this comment.
Yes, I should have caught that. I will make that change.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure to pass stream instead of handle and synchronize appropriately.
Closes #4236