Erdos-Renyi generator had bad logic in thrust calls #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
bug
seunghwak
approved these changes
Apr 22, 2024
|
|
||
| rmm::device_uvector<size_t> indices_v(count, handle.get_stream()); | ||
| auto generate_random_value = cuda::proclaim_return_type<float>([seed] __device__(size_t index) { | ||
| thrust::default_random_engine rng(seed); |
There was a problem hiding this comment.
This might be out side the scope of this bug fix PR, but should we better use raft::random::RngState? Using two different random number generation mechanism does not sound ideal.
There was a problem hiding this comment.
Created an issue to address this.
naimnv
approved these changes
Apr 22, 2024
jnke2016
approved these changes
Apr 22, 2024
|
/merge |
lvjing421
reviewed
Apr 25, 2024
| static_cast<vertex_t>(dst)); | ||
| })); | ||
|
|
||
| handle.sync_stream(); |
There was a problem hiding this comment.
Is it OK to leave out handle.sync_stream() here, as there is one after the kernel call in cpp/tests/generators/erdos_renyi_test.cpp?
There was a problem hiding this comment.
Yes. The sync_stream call here was never necessary. Any asynchronous work that is active on this stream will continue to be active when we leave this function call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
random_iterator, a thrust transform iterator that was used for counting and filtering returns the probability, but theycopy_ifcall was assuming it was returning the index.Modified the logic and then consolidated the
copy_ifandtransforminto a single call with an output iterator.Closes #4359