Test nx-cugraph package instead of editable install #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have the built package, so test that instead of an editable install. This helps avoid having to install the build dependencies for nx-cugraph at test time.
KyleFromNVIDIA
added
bug
bdice
approved these changes
May 28, 2024
There was a problem hiding this comment.
These changes look similar to what we have to do in cudf to get proper coverage. https://github.com/rapidsai/cudf/blob/8458306ecbc17d3977a98e2e33752b678394f588/ci/run_cudf_pytests.sh#L6
Looks good to me, as long as coverage is working as intended.
raydouglass
approved these changes
May 28, 2024
rlratzel
approved these changes
May 28, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have the built package, so test that instead of an editable install. This helps avoid having to install the build dependencies for nx-cugraph at test time.