Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin torch version in cugraph-dgl wheel test #4447

Merged
merged 2 commits into from
May 28, 2024
Merged

Pin torch version in cugraph-dgl wheel test #4447

merged 2 commits into from
May 28, 2024

Conversation

tingyu66
Copy link
Member

To fix the CI nightly issue in cugraph-dgl wheel test for CUDA 11.

@tingyu66 tingyu66 requested a review from a team as a code owner May 27, 2024 16:17
@github-actions github-actions bot added the ci label May 27, 2024
rlratzel
rlratzel approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Too bad this can't be consolidated somehow in dependencies.yaml, but I don't think wheel installs and the rapids-dependency-file-generator have the ability to inspect things like the NCCL install to do this.

@nv-rliu nv-rliu mentioned this pull request May 28, 2024
Closed
@tingyu66 tingyu66 added bug Something isn't working non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed bug Something isn't working labels May 28, 2024
@BradReesWork BradReesWork added this to the 24.06 milestone May 28, 2024
@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 562b5a5 into rapidsai:branch-24.06 May 28, 2024
131 checks passed
@tingyu66 tingyu66 deleted the fix-nightly-wheel-test branch May 28, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
24.06
Development

Successfully merging this pull request may close these issues.
4 participants
@tingyu66 @BradReesWork @rlratzel @AyodeAwe