Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lookup edge src dst using edge id and type #4449

Merged
merged 32 commits into from
Jun 29, 2024
Merged

Lookup edge src dst using edge id and type #4449

merged 32 commits into from
Jun 29, 2024

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented May 28, 2024 •
edited by ChuckHastings
Loading

Lookup edge src dst using edge id and type

Closes #4307

@naimnv naimnv requested review from a team as code owners May 28, 2024 23:52
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 28, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@naimnv naimnv requested review from ChuckHastings and seunghwak May 28, 2024 23:52
@naimnv naimnv self-assigned this May 28, 2024
@naimnv naimnv added the non-breaking Non-breaking change label May 28, 2024
@naimnv
Copy link
Contributor Author

naimnv commented May 28, 2024

/okay to test

@naimnv naimnv added the feature request New feature or request label May 28, 2024
@naimnv
Copy link
Contributor Author

naimnv commented May 29, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented May 29, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented May 29, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented May 29, 2024

/okay to test

@BradReesWork BradReesWork added this to the 24.06 milestone May 29, 2024
@naimnv
Copy link
Contributor Author

naimnv commented May 29, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented May 29, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented May 29, 2024

/okay to test

ChuckHastings
ChuckHastings reviewed May 29, 2024
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few items to address.

cpp/src/lookup/lookup_src_dst_impl.cuh Outdated Show resolved Hide resolved
cpp/src/lookup/lookup_src_dst_impl.cuh Show resolved Hide resolved
cpp/src/lookup/lookup_src_dst_impl.cuh Outdated Show resolved Hide resolved
cpp/src/lookup/lookup_src_dst_impl.cuh Outdated Show resolved Hide resolved
cpp/src/lookup/lookup_src_dst_impl.cuh Outdated Show resolved Hide resolved
seunghwak
seunghwak approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naimnv naimnv changed the base branch from branch-24.06 to branch-24.08 June 6, 2024 21:57
@naimnv
Copy link
Contributor Author

naimnv commented Jun 6, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Jun 10, 2024

/okay to test

alexbarghi-nv
alexbarghi-nv approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @naimnv can you write the C API for this in a separate PR? We'll need to expose this to Python.

@ChuckHastings
Copy link
Collaborator

Looks good to me. @naimnv can you write the C API for this in a separate PR? We'll need to expose this to Python.

Created #4481 to track that work.

@naimnv
Copy link
Contributor Author

naimnv commented Jun 19, 2024

@ChuckHastings Yes, I'm already working on it.

@naimnv
Copy link
Contributor Author

naimnv commented Jun 19, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Jun 20, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Jun 20, 2024 •
edited
Loading

Looks good to me. @naimnv can you write the C API for this in a separate PR? We'll need to expose this to Python.
@alexbarghi-nv Here is the draft PR for it.

@naimnv
Copy link
Contributor Author

naimnv commented Jun 20, 2024

/merge

@naimnv
Copy link
Contributor Author

naimnv commented Jun 24, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Jun 24, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Jun 28, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Jun 28, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Jun 28, 2024

/merge

@rapids-bot rapids-bot bot merged commit f0590ef into rapidsai:branch-24.08 Jun 29, 2024
137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@alexbarghi-nv alexbarghi-nv Awaiting requested review from alexbarghi-nv

Assignees

@naimnv naimnv

Labels
CMake cuGraph feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
24.08
Development

Successfully merging this pull request may close these issues.

Implement PLC/C/C++ lookup src/dst vertex from edge id
5 participants
@naimnv @BradReesWork @ChuckHastings @seunghwak @alexbarghi-nv