Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds benchmark for nx_cugraph.ego_graph #4451

Merged
merged 2 commits into from
May 30, 2024
Merged

Adds benchmark for nx_cugraph.ego_graph #4451

merged 2 commits into from
May 30, 2024

Conversation

rlratzel
Copy link
Contributor

Adds benchmark for nx_cugraph.ego_graph

Note: this code is not part of any installed package and does not affect the release. It is being added so it can be included in the branch-24.06 sources for reference.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 29, 2024
@rlratzel rlratzel added this to the 23.06 milestone May 29, 2024
@rlratzel rlratzel requested a review from eriknw May 29, 2024 21:58
@rlratzel rlratzel self-assigned this May 29, 2024
@rlratzel rlratzel requested review from a team and removed request for eriknw May 30, 2024 01:26
alexbarghi-nv
alexbarghi-nv approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv
Copy link
Member

/merge

eriknw
eriknw approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@eriknw eriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the common caveat that this algorithm seems difficult to benchmark well in ways that match "real world" use cases (i.e., how should we choose initial nodes and k?), and nx.ego_graph has more functionality than is exercised here.

@rapids-bot rapids-bot bot merged commit 563c06e into rapidsai:branch-24.06 May 30, 2024
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@eriknw eriknw eriknw approved these changes

Assignees

@rlratzel rlratzel

Labels
benchmarks improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
23.06
Development

Successfully merging this pull request may close these issues.
3 participants
@rlratzel @alexbarghi-nv @eriknw