Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code base to reduce memory requirement for building libcugraph #4506

Merged
merged 11 commits into from
Jun 28, 2024
Merged

Refactor code base to reduce memory requirement for building libcugraph #4506

merged 11 commits into from
Jun 28, 2024

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Jun 26, 2024 •
edited
Loading

Refactor code base to reduce memory requirement for building libcugraph.

  • split all sg.cu and mg.cu files into three files for three combination of (vertex_t, edge_t ), i.e, (32 bit, 32bit), (32 bit, 64bit), (64 bit, 64bit)

@naimnv naimnv requested review from a team as code owners June 26, 2024 14:43
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 26, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@naimnv naimnv self-assigned this Jun 26, 2024
@naimnv naimnv added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 26, 2024
@naimnv
Copy link
Contributor Author

naimnv commented Jun 26, 2024

/okay to test

@naimnv naimnv changed the title Refactor code base to reduce memory requirement for compiling libcugraph Refactor code base to reduce memory requirement for building libcugraph Jun 26, 2024
seunghwak
seunghwak reviewed Jun 26, 2024
View reviewed changes
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor

bdice commented Jun 26, 2024

Would a naming scheme like ..._sg_v32_e64.cu be acceptable?

I think separators between the numerical values and a one-character label like v or e would be more readable and convey more helpful information. If you wanted to split by weights float/double later, you could suffix with _wf or _wd.

seunghwak
seunghwak reviewed Jun 27, 2024
View reviewed changes
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@naimnv
Copy link
Contributor Author

naimnv commented Jun 28, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Jun 28, 2024

/okay to test

seunghwak
seunghwak approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

ChuckHastings
ChuckHastings approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugly but effective.

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit fd90b98 into rapidsai:branch-24.08 Jun 28, 2024
132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnke2016 jnke2016 jnke2016 approved these changes

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@rlratzel rlratzel Awaiting requested review from rlratzel

Assignees

@naimnv naimnv

Labels
CMake cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@naimnv @bdice @ChuckHastings @seunghwak @jnke2016