Refactor C++ unit tests to allow finer grained filtering #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
improvement
jnke2016
approved these changes
Jul 13, 2024
seunghwak
approved these changes
Jul 17, 2024
| ::testing::Values(cugraph::test::File_Usecase("test/datasets/karate.mtx")))); | ||
|
|
||
| INSTANTIATE_TEST_SUITE_P( | ||
| file_large_pass, |
There was a problem hiding this comment.
Why are we using "file_large_test" above and "file_large_pass" here? Better be consistent?
There was a problem hiding this comment.
Updated eigenvector centrality test names to match.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running all of the C++ unit tests can take a long time.
This PR splits the file-based tests into small versus large tests. The large tests (usually named file_large_test) can be skipped by setting the following environment variable:
export GTEST_FILTER="-*large*"You can skip both the large tests and the benchmark tests with the following:
export GTEST_FILTER="-*benchmark*:*large*"By default all tests will be run.