-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-configure benchmarking devices & add markers to bench_cugraph_uniform_neighbor_sample
#4561
Re-configure benchmarking devices & add markers to bench_cugraph_uniform_neighbor_sample
#4561
Conversation
This PR is targeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think the pytest
marker changes will help ensure the benchmark actually runs.
For my own understanding ... why is it desirable to remove the ability to configure which GPUs on the system are used? (this is just for my own curiosity... can answer this after you merge)
Hi James. Thanks for the question. |
/merge |
This PR re-enables the
benchmarks/cugraph/pytest-based/bench_cugraph_uniform_neighbor_sample.py
benchmark in the MNMG nightlies.This benchmark was previously being skipped due to the fact that the benchmarks are configured to run with Pytest markers
"managedmem_off and poolallocator_on"
. Thanks to @jameslamb for spotting this insideconftest.py
By adding the missing markers to the test (and removing some
dgx
machine specific dask-client configs), the benchmark should properly run in the nightly jobs.