-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ucx-py version, use UCX 1.17.0 in pip devcontainers #4562
Conversation
@@ -72,15 +72,17 @@ DEPENDENCIES=( | |||
ucx-py | |||
rapids-dask-dependency | |||
) | |||
for DEP in "${DEPENDENCIES[@]}"; do | |||
for FILE in dependencies.yaml conda/environments/*.yaml python/cugraph-{pyg,dgl}/conda/*.yaml; do | |||
for FILE in dependencies.yaml conda/environments/*.yaml python/cugraph-{pyg,dgl}/conda/*.yaml; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched the iteration order of this double-for loop. That way we only find-replace ucx-py one time instead of once for every other dependency.
done | ||
for FILE in python/**/pyproject.toml python/**/**/pyproject.toml; do | ||
sed_runner "/-.* ucx-py\(-cu[[:digit:]]\{2\}\)\{0,1\}==/ s/==.*/==${NEXT_UCX_PY_VERSION}.*,>=0.0.0a0/g" "${FILE}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The important change is that the ucx-py logic was not handling -cu11
/ -cu12
suffixes. Now it does.
I merged latest A few jobs immediately failed, like this:
A manual re-run fixed that for the The |
Looks like that's because there aren't any That matches what I see at the most recent Since we want to be using UCX 1.17.0 anyway (rapidsai/build-planning#77), I've just updated to that here: 6e61cd6 I should have done that in this repo after rapidsai/devcontainers#338 anyway. I'll go propose similar changes across the other repos using the devcontainers UCX feature (see rapidsai/devcontainers#273 for reference list). |
/merge |
Back ports the `update-version.sh` fixes from #4562
Fixes ucx-py dependency in
dependencies.yaml
andupdate-version.sh
.Updates to UCX 1.17.0 in pip devcontainers. (context: #4562 (comment)).