Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_property_graph_mg Usage of Util Function #4600

Merged

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Aug 7, 2024

This PR fixes an issue that recently arose due to a change in constructing a cudf.Series object.

test_property_graph_mg.py uses a function from utilities/utils.py to construct a Series object from 2d arrays. The function is now using the correct cudf.Series._from_column API.

@nv-rliu nv-rliu added bug Something isn't working improvement Improvement / enhancement to an existing function breaking Breaking change labels Aug 7, 2024
@nv-rliu nv-rliu added this to the 24.10 milestone Aug 7, 2024
@nv-rliu nv-rliu requested a review from a team as a code owner August 7, 2024 21:08
@nv-rliu nv-rliu removed the improvement Improvement / enhancement to an existing function label Aug 7, 2024
@github-actions github-actions bot added improvement Improvement / enhancement to an existing function python labels Aug 7, 2024
@nv-rliu nv-rliu added non-breaking Non-breaking change and removed breaking Breaking change labels Aug 7, 2024
@rlratzel
Copy link
Contributor

rlratzel commented Aug 7, 2024

@nv-rliu mentioned that the change here uses a non-public API that was recommended by cuDF devs (cc @bdice )

@rlratzel rlratzel removed the improvement Improvement / enhancement to an existing function label Aug 8, 2024
@rlratzel
Copy link
Contributor

rlratzel commented Aug 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit d92c257 into rapidsai:branch-24.10 Aug 8, 2024
147 checks passed
@nv-rliu nv-rliu deleted the fix-test-property-graph-mg branch August 15, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants