Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a bunch of legacy code that's no longer used #4609

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Remove a bunch of legacy code that's no longer used #4609

merged 8 commits into from
Aug 21, 2024

Conversation

ChuckHastings
Copy link
Collaborator

Supersedes #4553. That PR identified some issues with legacy code that's not really necessary anymore.

This PR removes the graph_utils.cuh file and gets rid of a few straggling functions that still used it.

@ChuckHastings ChuckHastings self-assigned this Aug 14, 2024
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed cuGraph labels Aug 14, 2024
@ChuckHastings ChuckHastings added this to the 24.10 milestone Aug 14, 2024
@ChuckHastings ChuckHastings marked this pull request as ready for review August 14, 2024 03:55
@ChuckHastings ChuckHastings requested a review from a team as a code owner August 14, 2024 03:55
@robertmaynard robertmaynard mentioned this pull request Aug 14, 2024
Closed
@ChuckHastings
add back source_indices function... begrudingly. It's required by som…
640a636 
…e legacy python code. Refactored to use new technique
@ChuckHastings
Copy link
Collaborator Author

@seunghwak - had to add back in the source_indices function. It's currently used by python. I refactored it to use code copied out of one of the new functions. We'll add issues to remove that functionality.

@ChuckHastings
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit 3db77b3 into rapidsai:branch-24.10 Aug 21, 2024
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@seunghwak seunghwak Awaiting requested review from seunghwak

Assignees

@ChuckHastings ChuckHastings

Labels
cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
24.10
Development

Successfully merging this pull request may close these issues.
3 participants
@ChuckHastings @robertmaynard @seunghwak