Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ListColumn constructor argument #4620

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix ListColumn constructor argument #4620

merged 1 commit into from
Aug 20, 2024

Conversation

mroeschke
Copy link
Contributor

A recent API change in cudf (rapidsai/cudf#16465) now requires the data argument to be passed (consistent with the other Column subclasses)

@mroeschke mroeschke requested a review from a team as a code owner August 20, 2024 01:59
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 20, 2024
rlratzel
rlratzel approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 710f268 into rapidsai:branch-24.10 Aug 20, 2024
103 checks passed
@mroeschke mroeschke deleted the fix/listcolumn/api branch August 20, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @rlratzel @ChuckHastings