Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed ci build_docs to just upload the xml so the cugraph-docs can create the docs #4662

Merged
merged 17 commits into from
Dec 13, 2024
Merged

Changed ci build_docs to just upload the xml so the cugraph-docs can create the docs #4662

merged 17 commits into from
Dec 13, 2024

Conversation

acostadon
Copy link
Contributor

… create the docs

@acostadon acostadon requested a review from a team as a code owner September 23, 2024 17:22
@github-actions github-actions bot added the ci label Sep 23, 2024
@acostadon acostadon marked this pull request as draft September 23, 2024 17:23
@acostadon acostadon added doc Documentation cuGraph labels Sep 23, 2024
@acostadon acostadon added this to the 24.10 milestone Sep 23, 2024
@acostadon acostadon marked this pull request as ready for review September 23, 2024 19:16
@acostadon acostadon added the non-breaking Non-breaking change label Sep 24, 2024
BradReesWork
BradReesWork requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 31 - 61 should also be redone. Since cugraph no longer builds the full set of Docs, there is no need to bring in the other external packages

@jameslamb jameslamb changed the title Changed ci build_docss to just upload the xml so the cugraph-docs can… Changed ci build_docss to just upload the xml so the cugraph-docs can create the docs Sep 27, 2024
@jameslamb jameslamb mentioned this pull request Sep 27, 2024
Merged
jameslamb
jameslamb reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool, hadn't noticed this PR before! @ me any time you've addressed other comments and are ready for a ci-codeowners review (since I'd been helping over in rapidsai/cugraph-docs#46)

@BradReesWork BradReesWork modified the milestones: 24.10, 24.12 Sep 30, 2024
@BradReesWork BradReesWork changed the base branch from branch-24.10 to branch-24.12 September 30, 2024 19:20
@jameslamb jameslamb changed the title Changed ci build_docss to just upload the xml so the cugraph-docs can create the docs Changed ci build_docs to just upload the xml so the cugraph-docs can create the docs Oct 14, 2024
@jameslamb jameslamb mentioned this pull request Oct 14, 2024
Closed
@acostadon acostadon modified the milestones: 24.12, 25.02 Nov 22, 2024
@github-actions github-actions bot removed the cuGraph label Nov 22, 2024
@AyodeAwe AyodeAwe changed the base branch from branch-24.12 to branch-25.02 December 6, 2024 17:41
@acostadon acostadon self-assigned this Dec 10, 2024
@AyodeAwe
Copy link
Contributor

@BradReesWork could you take a second look at this PR?

BradReesWork
BradReesWork approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you verify that this will actually push the xml file?

@acostadon acostadon requested a review from jameslamb December 10, 2024 16:30
@AyodeAwe
Copy link
Contributor

did you verify that this will actually push the xml file?

Confirmed in a previous run shown here: https://github.com/rapidsai/cugraph/actions/runs/12203540777/job/34049336099#step:10:11180

But we'll wait for the docs build in this new run to confirm again anyway.

@AyodeAwe
Copy link
Contributor

Looks like the dgl package is still needed:

image

https://github.com/rapidsai/cugraph/actions/runs/12261494613/job/34211741255#step:10:9320

@AyodeAwe
Copy link
Contributor

Looks like the pyg package is needed too still:

image

@AyodeAwe
Copy link
Contributor

AyodeAwe commented Dec 11, 2024 •
edited
Loading

wholegraph seems needed too:

image

@AyodeAwe
Copy link
Contributor

AyodeAwe commented Dec 11, 2024 •
edited
Loading

Docs build now passing:

image
https://github.com/rapidsai/cugraph/actions/runs/12280428843/job/34270317614?pr=4662#step:10:11205

I've also confirmed by downloading and checking the xml tar uploaded to s3

@AyodeAwe
Copy link
Contributor

@BradReesWork for a second review on this.

I've had to re-add the external packages previously removed due to the documentation build still needing it (see comments above this one).

@AyodeAwe AyodeAwe merged commit 3ad4949 into rapidsai:branch-25.02 Dec 13, 2024
26 of 44 checks passed
@AyodeAwe
Copy link
Contributor

Upload confirmed from branch build: https://github.com/rapidsai/cugraph/actions/runs/12317133575/job/34383555117#step:10:11097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@raydouglass raydouglass Awaiting requested review from raydouglass raydouglass is a code owner automatically assigned from rapidsai/ci-codeowners

@jameslamb jameslamb Awaiting requested review from jameslamb

Assignees

@acostadon acostadon

Labels
ci doc Documentation non-breaking Non-breaking change
Projects
None yet
Milestone
25.02
Development

Successfully merging this pull request may close these issues.
4 participants
@acostadon @AyodeAwe @jameslamb @BradReesWork