Skip to content

Commit

Permalink
Add libfaiss runtime dependency to libcuml. (#5284)
Browse files Browse the repository at this point in the history
Fixes an issue with #5281

libfaiss is required at runtime, and thus must be specified as a libcuml runtime dependency.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Charles Blackmon-Luca (https://github.com/charlesbluca)
  - Sevag H (https://github.com/sevagh)

URL: #5284
  • Loading branch information
bdice authored Mar 20, 2023
1 parent 222121d commit 6976c8b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions conda/recipes/libcuml/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ outputs:
- libraft-headers ={{ minor_version }}
- libraft-nn ={{ minor_version }}
- treelite {{ treelite_version }}
- libfaiss>=1.7.1
- faiss-proc=*=cuda
about:
home: https://rapids.ai/
license: Apache-2.0
Expand Down
4 changes: 2 additions & 2 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,8 @@ if(BUILD_CUML_CPP_LIBRARY)

# These are always private:
list(APPEND _cuml_cpp_private_libs
raft::raft
$<$<BOOL:${CUML_USE_RAFT_NN}>:faiss>
$<TARGET_NAME_IF_EXISTS:GPUTreeShap::GPUTreeShap>
$<$<BOOL:${LINK_CUFFT}>:CUDA::cufft${_ctk_static_suffix}>
${TREELITE_LIBS}
Expand All @@ -604,8 +606,6 @@ if(BUILD_CUML_CPP_LIBRARY)
# because cumlprims_mg and cuML inherit their CUDA libs from the raft::raft
# INTERFACE target.
list(APPEND ${_cuml_cpp_libs_var_name}
raft::raft
$<$<BOOL:${CUML_USE_RAFT_NN}>:faiss>
$<$<BOOL:${CUML_USE_RAFT_NN}>:raft::nn>
$<$<BOOL:${CUML_USE_RAFT_DIST}>:raft::distance>
$<TARGET_NAME_IF_EXISTS:cumlprims_mg::cumlprims_mg>
Expand Down

0 comments on commit 6976c8b

Please sign in to comment.