Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nightly CI tests: Use CUDA_REL variable in gpu build.sh script #4581

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Fix for nightly CI tests: Use CUDA_REL variable in gpu build.sh script #4581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c5208e
FIX Use CUDA_REL variable in gpu build.sh script
dantegd Feb 15, 2022
7683fc0
FIX Remove treshold of mismatched elemnts of rbc test
dantegd Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/gpu/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ else

# FIXME: Project FLASH only builds for python version 3.8 which is the one used in
# the CUDA 11.0 job, need to change all versions to project flash
if [ "$PYTHON" == "3.8" ];then
if [ "$CUDA_REL" == "11.0" ];then
gpuci_logger "Using Project FLASH to install cuml python"
CONDA_FILE=`find ${CONDA_ARTIFACT_PATH} -name "cuml*.tar.bz2"`
CONDA_FILE=`basename "$CONDA_FILE" .tar.bz2` #get filename without extension
Expand Down
10 changes: 2 additions & 8 deletions python/cuml/test/test_nearest_neighbors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,14 +547,8 @@ def test_nearest_neighbors_rbc(distance, n_neighbors, nrows):
brute_d, brute_i = knn_cu_brute.kneighbors(
X[:query_rows, :], n_neighbors=n_neighbors)

rbc_i = cp.sort(rbc_i, axis=1)
brute_i = cp.sort(brute_i, axis=1)

# TODO: These are failing with 1 or 2 mismatched elements
# for very small values of k:
# https://github.com/rapidsai/cuml/issues/4262
assert len(brute_d[brute_d != rbc_d]) <= 3
assert len(brute_i[brute_i != rbc_i]) <= 3
assert len(brute_d[brute_d != rbc_d]) == 0
assert len(brute_i[brute_i != rbc_i]) == 0


@pytest.mark.parametrize("metric", valid_metrics_sparse())
Expand Down