Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declare cuda-python dependency for wheels, other small packaging changes #6217

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 10, 2025

Follow-up to #6190.

Proposes some miscellaneous packaging cleanup:

Notes for Reviewers

These changes are useful independently, but will also make the libcuml wheels PR (#6199) a bit smaller and easier to review.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 10, 2025

This comment was marked as resolved.

@jameslamb jameslamb changed the title WIP: declare cuda-python dependency for wheels, other small packaging changes declare cuda-python dependency for wheels, other small packaging changes Jan 11, 2025
@jameslamb jameslamb marked this pull request as ready for review January 11, 2025 00:19
@jameslamb jameslamb requested review from a team as code owners January 11, 2025 00:19
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion I'd like to see for the gitignore but nothing really blocking. Generally LGTM.

.gitignore Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Show resolved Hide resolved
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 47bac70 into rapidsai:branch-25.02 Jan 14, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CMake CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants