Pin cuml dependency in notebook testing environment to nightlies #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
reviewed
May 1, 2023
There was a problem hiding this comment.
Can you add an entry for cuml in the update-version.sh block below?
cuspatial/ci/release/update-version.sh
Lines 44 to 50 in 021c1f2
Also, since you'll be touching this file, would you mind updating those few lines of code to be consistent with my comment below?
In particular, removing the variable from the sed search pattern would be great.
Merged
3 tasks
the `==23.6.*` specifier is compatible with both `conda` and `pip`, which is why we opt to use that pattern for our dependencies now that we are publishing wheels
the `NEXT_SHORT_TAG_PEP440` values are compatible with both `conda` and `pip`
ajschmidt8
reviewed
May 1, 2023
Comment on lines
+59
to
+60
| sed_runner "/- &cudf_conda cudf==/ s/==.*/==${NEXT_SHORT_TAG_PEP440}\.*/g" ${FILE} | ||
| sed_runner "/- cudf==/ s/==.*/==${NEXT_SHORT_TAG_PEP440}\.*/g" ${FILE} |
There was a problem hiding this comment.
for now there is a bit of duplication necessary here for cudf.
it will be removed in the future when we revamp these scripts and the process around them.
ajschmidt8
approved these changes
May 1, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR pins cuml dependency in notebook testing environment to nightlies as required in the CI environment.
Checklist