Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odd __version__ reported #336

Closed
jakirkham opened this issue Jul 2, 2020 · 12 comments · Fixed by #448 or #948
Closed

Odd __version__ reported #336

jakirkham opened this issue Jul 2, 2020 · 12 comments · Fixed by #448 or #948
Labels
bug Something isn't working

Comments

@jakirkham
Copy link
Member

Appears the version may not be working correctly here.

In [1]: import dask_cuda                                                        
    
In [2]: dask_cuda.__version__                                                   
Out[2]: '0+unknown'
@quasiben
Copy link
Member

quasiben commented Jul 6, 2020

Seeing the same as well from conda and from pypi but not from source

@pentschev
Copy link
Member

I can confirm this is still an issue with conda packages, but installing from source works properly.

@jakirkham jakirkham mentioned this issue Nov 30, 2020
Merged
@jakirkham
Copy link
Member Author

I think PR ( #448 ) should address this.

@jakirkham
Copy link
Member Author

With the new packages, this is now reported correctly.

In [1]: import dask_cuda

In [2]: dask_cuda.__version__
Out[2]: '0.17.0a+46.ge77a3fe'

@jakirkham jakirkham reopened this Dec 7, 2020
@jakirkham
Copy link
Member Author

Reopening as we had to revert part of PR ( #448 ) with PR ( #466 ) as it was breaking PyPI uploads. See issue ( pypi/warehouse#8891 ) for more context as to why that is. Am reopening this as the issue presents (at least based on my local testing) with that reversion. Will need to figure out another way forward that doesn't breaking PyPI uploads and does include the version.

@pentschev pentschev added the bug Something isn't working label Jan 8, 2021
@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@jakirkham
Copy link
Member Author

This is still an issue. We tried to fix it, but the fix broke package building and uploading. So we had to revert. Need to investigate a new fix

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@pentschev
Copy link
Member

Just for a quick update, this issue still remains.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@jakirkham
Copy link
Member Author

cc @wence-

@wence- wence- mentioned this issue Jul 12, 2022
Merged
wence- added a commit to wence-/dask-cuda that referenced this issue Jul 12, 2022
@wence-
Override versioneer.get_versions when GIT_DESCRIBE_TAG is defined
221c883 
Per PEP440, local version identifiers are disallowed for uploads to
public index servers. In CI, when we build pypi packages, we override
the versioneer-provided version with a PEP440-compatible version by
defining GIT_DESCRIBE_TAG and VERSION_SUFFIX. These are glued together
to produce a version which we then use to override the version
produced by versioneer.

This leaves us free to use the command classes provided by versioneer
in all circumstances. Closes rapidsai#336.
@rapids-bot rapids-bot bot closed this as completed in #948 Jul 25, 2022
rapids-bot bot pushed a commit that referenced this issue Jul 25, 2022
@wence-
Always use versioneer command classes in setup.py (#948)
364cba2 
The `GIT_DESCRIBE_TAG` and `VERSION_SUFFIX` environment variables are used
to control the name and version of the created conda/pypi package.
They should, however, not be used to control the version of the
installed package by overriding the versioneer cmdclass since that
leaves an unmodified _version.py file in the installed package
directory. A consequence is that the version reported by
`dask_cuda.__version__` is `"0+unknown"`. 

We cannot always use the versioneer-provided cmdclass unmodified since
PEP440 specifically forbids PyPI from accepting packages that have local
version identifiers (as used by versioneer). To get around this, when setup.py
detects it is building a PyPI package (`GIT_DESCRIBE_TAG` is in the environment),
patch the version returned from versioneer with a PyPI-compatible one.

While we're here, bring the conda version string into line with the
rest of the rapids ecosystem.

Closes #336.

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #948
@wence- wence- mentioned this issue Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@quasiben @jakirkham @pentschev