Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using stream-ordered and managed RMM allocators in benchmarks #1012

Merged

Conversation

pentschev
Copy link
Member

@pentschev pentschev commented Oct 11, 2022

This change requires UCX 1.14 for async support from openucx/ucx#8623 and UVM fixes from openucx/ucx#8754 .

@github-actions github-actions bot added the python python code needed label Oct 11, 2022
@pentschev pentschev added 2 - In Progress Currently a work in progress feature request New feature or request non-breaking Non-breaking change and removed python python code needed labels Oct 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Base: 0.00% // Head: 63.84% // Increases project coverage by +63.84% 🎉

Coverage data is based on head (32f7903) compared to base (8c87288).
Patch coverage: 58.20% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           branch-23.02    #1012       +/-   ##
=================================================
+ Coverage          0.00%   63.84%   +63.84%     
=================================================
  Files                26       25        -1     
  Lines              3439     3175      -264     
=================================================
+ Hits                  0     2027     +2027     
+ Misses             3439     1148     -2291     
Impacted Files Coverage Δ
dask_cuda/benchmarks/common.py 0.00% <0.00%> (ø)
dask_cuda/benchmarks/local_cudf_groupby.py 0.00% <ø> (ø)
dask_cuda/benchmarks/local_cudf_shuffle.py 0.00% <0.00%> (ø)
dask_cuda/benchmarks/utils.py 0.00% <0.00%> (ø)
dask_cuda/disk_io.py 56.19% <ø> (+56.19%) ⬆️
dask_cuda/initialize.py 87.23% <ø> (+87.23%) ⬆️
dask_cuda/is_spillable_object.py 84.37% <ø> (+84.37%) ⬆️
dask_cuda/proxy_object.py 90.52% <ø> (+90.52%) ⬆️
dask_cuda/cli.py 86.40% <72.50%> (ø)
dask_cuda/utils.py 83.47% <82.35%> (+83.47%) ⬆️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue python python code needed labels Jan 12, 2023
@pentschev pentschev changed the base branch from branch-22.12 to branch-23.02 January 12, 2023 09:48
@github-actions github-actions bot removed conda conda issue gpuCI gpuCI issue labels Jan 12, 2023
@github-actions github-actions bot added the gpuCI gpuCI issue label Feb 3, 2023
@pentschev pentschev changed the base branch from branch-23.02 to branch-23.04 February 13, 2023 16:14
@pentschev pentschev marked this pull request as ready for review February 13, 2023 16:17
@pentschev pentschev requested a review from a team as a code owner February 13, 2023 16:17
@pentschev pentschev added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Feb 13, 2023
@pentschev
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit a0fda76 into rapidsai:branch-23.04 Feb 13, 2023
@pentschev pentschev deleted the benchmarks-rmm-async-managed branch February 28, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request gpuCI gpuCI issue non-breaking Non-breaking change python python code needed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants