Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass missing argument to groupby benchmark compute #1069

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

mattf
Copy link
Contributor

@mattf mattf commented Dec 21, 2022

No description provided.

@mattf mattf requested a review from a team as a code owner December 21, 2022 17:18
@github-actions github-actions bot added the python python code needed label Dec 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2023

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (9f5a97f) compared to base (8c87288).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 9f5a97f differs from pull request most recent head a2ac894. Consider uploading reports for the commit a2ac894 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           branch-23.02   #1069   +/-   ##
============================================
  Coverage          0.00%   0.00%           
============================================
  Files                26      26           
  Lines              3439    3433    -6     
============================================
+ Misses             3439    3433    -6     
Impacted Files Coverage Δ
dask_cuda/benchmarks/local_cudf_groupby.py 0.00% <ø> (ø)
dask_cuda/cuda_worker.py 0.00% <0.00%> (ø)
dask_cuda/local_cuda_cluster.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8 ajschmidt8 mentioned this pull request Jan 1, 2023
3 tasks
@pentschev pentschev changed the title complete #994, allow running when __name__ == '__main__' Pass missing backend argument to groupby benchmark compute function Jan 3, 2023
@pentschev pentschev changed the title Pass missing backend argument to groupby benchmark compute function Pass missing argument to groupby benchmark compute Jan 3, 2023
@pentschev
Copy link
Member

Failures are unrelated, opened #1070 to track the issue.

@pentschev pentschev added bug Something isn't working 5 - Ready to Merge Testing and reviews complete, ready to merge non-breaking Non-breaking change labels Jan 3, 2023
@pentschev
Copy link
Member

rerun tests

@pentschev
Copy link
Member

Thanks @mattf for the fix!

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 10b73ac into rapidsai:branch-23.02 Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants