Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure consistent results from safe_sizeof() in test #1071

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Ensure consistent results from safe_sizeof() in test #1071

merged 1 commit into from
Jan 3, 2023

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Jan 3, 2023 •
edited by pentschev
Loading

Probe __cuda_array_interface__ in test_device_host_file_step_by_step, to get consistent results from safe_sizeof().

Fixes #1070

@github-actions github-actions bot added the python python code needed label Jan 3, 2023
@madsbk madsbk added bug Something isn't working non-breaking Non-breaking change labels Jan 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023 •
edited
Loading

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (4f1a253) compared to base (8c87288).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@              Coverage Diff               @@
##           branch-23.02   #1071     +/-   ##
==============================================
  Coverage          0.00%   0.00%             
==============================================
  Files                26      18      -8     
  Lines              3439    2253   -1186     
==============================================
+ Misses             3439    2253   -1186
Impacted Files Coverage Δ
dask_cuda/cuda_worker.py 0.00% <0.00%> (ø)
dask_cuda/local_cuda_cluster.py 0.00% <0.00%> (ø)
dask_cuda/benchmarks/local_cupy.py
dask_cuda/benchmarks/local_cudf_groupby.py
dask_cuda/benchmarks/utils.py
dask_cuda/benchmarks/local_cudf_merge.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/_version.py
dask_cuda/benchmarks/common.py
dask_cuda/benchmarks/local_cupy_map_overlap.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@madsbk madsbk marked this pull request as ready for review January 3, 2023 12:50
@madsbk madsbk requested a review from a team as a code owner January 3, 2023 12:50
@pentschev pentschev changed the title Probe __cuda_array_interface__ in test, to get consistent results from safe_sizeof() Ensure consistent results from safe_sizeof() in test Jan 3, 2023
pentschev
pentschev approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks so much for the quick fix @madsbk !

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5baa89d into rapidsai:branch-23.02 Jan 3, 2023
@madsbk madsbk deleted the consistent_safe_sizeof_results_in_tests branch January 9, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_device_host_file_step_by_step test failing
3 participants
@madsbk @codecov-commenter @pentschev