Update cudf.Buffer pointer access method
#1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test that reads directly from `cudf.Buffer` pointer to new `get_ptr(mode="read")`, in accordance with changes from rapidsai/cudf#12587 .
pentschev
added
bug
galipremsagar
approved these changes
Jan 27, 2023
|
Thanks @galipremsagar ! |
|
/merge |
wence-
approved these changes
Jan 27, 2023
Codecov ReportBase: 87.90% // Head: 63.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #1094 +/- ##
=================================================
- Coverage 87.90% 63.88% -24.02%
=================================================
Files 17 25 +8
Lines 2298 3168 +870
=================================================
+ Hits 2020 2024 +4
- Misses 278 1144 +866
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test that reads directly from
cudf.Bufferpointer to newget_ptr(mode="read"), in accordance with changes from rapidsai/cudf#12587 .