Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to rapidsai/rmm#1221 which moves allocator callbacks #1129

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Feb 24, 2023

The allocator callbacks now live in their own submodules (so that RMM does not, for example, import pytorch unless required) and so must be explicitly imported.

The allocator callbacks now live in their own submodules (so that RMM
does not, for example, import pytorch unless required) and so must be
explicitly imported.
@github-actions github-actions bot added the python python code needed label Feb 24, 2023
@pentschev pentschev added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 28, 2023
@wence- wence- marked this pull request as ready for review February 28, 2023 09:44
@wence- wence- requested a review from a team as a code owner February 28, 2023 09:44
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Lawrence!

@pentschev
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit b9561cf into rapidsai:branch-23.04 Feb 28, 2023
rapids-bot bot pushed a commit that referenced this pull request Mar 9, 2023
Follow up to PR ( #1129 ) and PR ( rapidsai/rmm#1221 )

Uses `rmm_cupy_allocator` from `rmm.allocators.cupy` where it has been moved to recently.

cc @wence-

Authors:
  - https://github.com/jakirkham

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #1138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants