Drop Python 3.7 handling for pickle protocol 4 #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
improvement
Now that Python 3.8 is the minimum supported version, drop the special casing for Python 3.7's `HIGHEST_PROTOCOL`, which was 4 (not 5). In Python 3.8+, `HIGHEST_PROTOCOL >= 5`. So none of these branches are needed any more.
jakirkham
force-pushed
the
drop_py37_pkl_4_checks
branch
from
84dad52 to
ae05ca3
Compare
|
Toggling for CI |
|
Failures are unrelated, tracking that in #1134 . |
pentschev
approved these changes
Feb 28, 2023
|
/merge |
|
Thanks Peter & Mads! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1131
Now that Python 3.8 is the minimum supported version, drop the special casing for Python 3.7's
HIGHEST_PROTOCOL, which was 4 (not 5). In Python 3.8+,HIGHEST_PROTOCOL >= 5. So none of these branches are needed any more.