Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax CuPy pin #248

Merged
merged 4 commits into from
Mar 2, 2020
Merged

Relax CuPy pin #248

merged 4 commits into from
Mar 2, 2020

Conversation

jakirkham
Copy link
Member

Closes #241

Try relaxing the CuPy pin since we have made some changes to the package.

@raydouglass
Copy link
Member

Codecov Report

Merging #248 into branch-0.13 will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.13     #248   +/-   ##
============================================
  Coverage        76.29%   76.29%           
============================================
  Files               14       14           
  Lines              983      983           
============================================
  Hits               750      750           
  Misses             233      233

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd18b6f...455f10d. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 1, 2020 •
edited
Loading

Codecov Report

Merging #248 into branch-0.13 will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.13     #248      +/-   ##
===============================================
+ Coverage        76.29%   76.41%   +0.11%     
===============================================
  Files               14       14              
  Lines              983      988       +5     
===============================================
+ Hits               750      755       +5     
  Misses             233      233
Impacted Files Coverage Δ
dask_cuda/device_host_file.py 93.4% <100%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e76e00...6d15a5c. Read the comment docs.

@jakirkham jakirkham marked this pull request as ready for review March 1, 2020 03:40
@jakirkham jakirkham requested a review from a team as a code owner March 1, 2020 03:40
@jakirkham jakirkham changed the title [WIP] Relax CuPy pin Relax CuPy pin Mar 1, 2020
@jakirkham jakirkham mentioned this pull request Mar 1, 2020
Closed
pentschev
pentschev approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that we can now get rid of this. Thanks @jakirkham .

@jakirkham jakirkham requested a review from quasiben March 2, 2020 19:37
@quasiben
Copy link
Member

quasiben commented Mar 2, 2020

thanks @jakirkham

@quasiben quasiben merged commit eb68ba1 into rapidsai:branch-0.13 Mar 2, 2020
@jakirkham jakirkham deleted the relax_cupy_pin branch March 2, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillon-cullinan dillon-cullinan dillon-cullinan approved these changes

@pentschev pentschev pentschev approved these changes

@quasiben quasiben Awaiting requested review from quasiben

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CuPy 7.2 breaks CI
6 participants
@jakirkham @raydouglass @codecov-io @quasiben @pentschev @dillon-cullinan