-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-label PRs based on their content [skip-ci] #480
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #480 +/- ##
===============================================
+ Coverage 90.40% 91.35% +0.95%
===============================================
Files 15 18 +3
Lines 1126 1435 +309
===============================================
+ Hits 1018 1311 +293
- Misses 108 124 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few suggestions below. There are also a few files not handled like .coveragerc
, .readthedocs.yml
, setup.py
, etc. I'm not sure how we want to handle these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the labels listed in labeler.yml
don't yet exist in the repo, so they will likely need to be added.
@ajschmidt8 can you re-review? |
Sure. Also cc @pentschev in case you have thoughts here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one minor suggestion. Can include, alter, or skip. Looks good otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding docs/
is good too, otherwise LGTM.
@pentschev @jakirkham added |
@gpucibot merge |
This PR adds the GitHub action PR Labeler to auto-label PRs based on their content.
Labeling is managed with a configuration file
.github/labeler.yml
using the following options