Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-label PRs based on their content [skip-ci] #480

Merged
merged 8 commits into from
Feb 17, 2021
Merged

Conversation

jolorunyomi
Copy link
Contributor

@jolorunyomi jolorunyomi commented Dec 30, 2020

This PR adds the GitHub action PR Labeler to auto-label PRs based on their content.

Labeling is managed with a configuration file .github/labeler.yml using the following options

@jolorunyomi jolorunyomi requested a review from a team as a code owner December 30, 2020 18:12
@codecov-io
Copy link

codecov-io commented Dec 30, 2020

Codecov Report

Merging #480 (13e9130) into branch-0.18 (b170b29) will increase coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18     #480      +/-   ##
===============================================
+ Coverage        90.40%   91.35%   +0.95%     
===============================================
  Files               15       18       +3     
  Lines             1126     1435     +309     
===============================================
+ Hits              1018     1311     +293     
- Misses             108      124      +16     
Impacted Files Coverage Δ
dask_cuda/device_host_file.py 90.90% <0.00%> (-7.96%) ⬇️
dask_cuda/explicit_comms/utils.py 100.00% <0.00%> (ø)
dask_cuda/proxify_host_file.py 100.00% <0.00%> (ø)
dask_cuda/proxify_device_objects.py 91.83% <0.00%> (ø)
dask_cuda/get_device_memory_objects.py 89.04% <0.00%> (ø)
dask_cuda/explicit_comms/comms.py 99.02% <0.00%> (+0.01%) ⬆️
dask_cuda/cli/dask_cuda_worker.py 96.92% <0.00%> (+0.09%) ⬆️
dask_cuda/local_cuda_cluster.py 81.17% <0.00%> (+0.68%) ⬆️
dask_cuda/cuda_worker.py 78.75% <0.00%> (+1.73%) ⬆️
dask_cuda/proxy_object.py 89.80% <0.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b170b29...3882a8a. Read the comment docs.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few suggestions below. There are also a few files not handled like .coveragerc, .readthedocs.yml, setup.py, etc. I'm not sure how we want to handle these.

.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
@pentschev pentschev added the 2 - In Progress Currently a work in progress label Jan 8, 2021
@jolorunyomi jolorunyomi requested a review from jakirkham January 9, 2021 05:41
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the labels listed in labeler.yml don't yet exist in the repo, so they will likely need to be added.

.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Show resolved Hide resolved
@jolorunyomi jolorunyomi changed the title Create labeler.yml update pr-labeler configuration Jan 28, 2021
@jolorunyomi jolorunyomi changed the title update pr-labeler configuration Auto-label PRs based on their content [skip-ci] Jan 29, 2021
@mike-wendt
Copy link
Contributor

@ajschmidt8 can you re-review?
@jakirkham can you review for this repo?

@mike-wendt mike-wendt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed 2 - In Progress Currently a work in progress labels Feb 2, 2021
@jakirkham
Copy link
Member

Sure. Also cc @pentschev in case you have thoughts here

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one minor suggestion. Can include, alter, or skip. Looks good otherwise

.github/labeler.yml Show resolved Hide resolved
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding docs/ is good too, otherwise LGTM.

@mike-wendt
Copy link
Contributor

@pentschev @jakirkham added doc label to docs/ path

@mike-wendt
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e560f8a into branch-0.18 Feb 17, 2021
@mike-wendt mike-wendt deleted the pr-labeler branch February 17, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants