Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device synchronization in local_cupy benchmark #518

Merged

Conversation

pentschev
Copy link
Member

The way the code was written would pass the client's device to each worker and synchronize on that, which is wrong. This was catched due to recent changes to Distributed, where the following was raised:

Task exception was never retrieved
future: <Task finished coro=<Scheduler.broadcast.<locals>.send_message() done, defined at /datasets/pentschev/miniconda3/envs/gdf/lib/python3.7/site-packages/distributed/scheduler.py:4965> exception=Exception("unhashable type: 'cupy.cuda.device.Device'")>
Traceback (most recent call last):
  File "/datasets/pentschev/miniconda3/envs/gdf/lib/python3.7/site-packages/distributed/scheduler.py", line 4969, in send_message
    resp = await send_recv(comm, close=True, serializers=serializers, **msg)
  File "/datasets/pentschev/miniconda3/envs/gdf/lib/python3.7/site-packages/distributed/core.py", line 662, in send_recv
    raise Exception(response["text"])
Exception: unhashable type: 'cupy.cuda.device.Device'

@pentschev pentschev requested a review from a team as a code owner February 9, 2021 18:19
@pentschev pentschev added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Feb 9, 2021
@pentschev
Copy link
Member Author

@charlesbluca make sure you have this patch as well before running anything the local_cupy.py benchmark, or you'll get the errors above as well on latest Distributed.

@pentschev pentschev added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 9, 2021
@pentschev
Copy link
Member Author

Thanks @quasiben for reviewing

@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f9ce83a into rapidsai:branch-0.18 Feb 9, 2021
@pentschev pentschev deleted the fix-local-cupy-device-sync branch February 10, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants