Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useless property #944

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Fix useless property #944

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05012c5
Remove unused jit_unspill property
wence- Jul 4, 2022
31e3776
Fix data constructor if memory limits are None
wence- Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dask_cuda/cuda_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def del_pid_file():
if jit_unspill is None:
jit_unspill = dask.config.get("jit-unspill", default=False)
if device_memory_limit is None and memory_limit is None:
data = {}
data = lambda _: {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breakage was not spotted by the test suite

TODO:

  • introduce test that exercises this code path.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe data = dict here would make more sense? A lambda to return an empty dict looks a bit weird.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data is later called with a single argument which should be ignored in the dict case, so I don't think data = dict will work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, I overlooked the argument. Let's leave it like this then.

elif jit_unspill:
data = lambda i: (
ProxifyHostFile,
Expand Down