Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix distributed error related to loop_in_thread #963

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR fixes following errors in pytest with latest distributed:

  @pytest.mark.parametrize("delayed", [True, False])
  def test_basic(loop, delayed):  # noqa: F811
file /nvme/0/pgali/envs/cudfdev/lib/python3.9/site-packages/distributed/utils_test.py, line 145
  @pytest.fixture
  def loop(loop_in_thread):
E       fixture 'loop_in_thread' not found
>       available fixtures: benchmark, benchmark_weave, cache, capfd, capfdbinary, caplog, capsys, capsysbinary, cleanup, current_cases, doctest_namespace, loop, monkeypatch, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, testrun_uid, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, worker_id
>       use 'pytest --fixtures [testpath]' for help on them.

/nvme/0/pgali/envs/cudfdev/lib/python3.9/site-packages/distributed/utils_test.py:145

@galipremsagar galipremsagar requested a review from a team as a code owner August 2, 2022 15:03
@galipremsagar galipremsagar changed the title [REVIEW] Fix distributed error related to loop_in_thread [REVIEW] Fix distributed error related to loop_in_thread Aug 2, 2022
@galipremsagar galipremsagar self-assigned this Aug 2, 2022
@github-actions github-actions bot added the python python code needed label Aug 2, 2022
@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change and removed python python code needed labels Aug 2, 2022
@github-actions github-actions bot added the python python code needed label Aug 2, 2022
@wence-
Copy link
Contributor

wence- commented Aug 2, 2022

I think this looks fine, although note ongoing discussion in dask/distributed#6806 about the publicness of this module in distributed.

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @galipremsagar !

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #963 (d0a0be7) into branch-22.08 (283a087) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           branch-22.08    #963   +/-   ##
============================================
  Coverage          0.00%   0.00%           
============================================
  Files                16      16           
  Lines              2108    2108           
============================================
  Misses             2108    2108           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 283a087...d0a0be7. Read the comment docs.

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c1e3be4 into rapidsai:branch-22.08 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants