Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up dependency lists #241

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Clean up dependency lists #241

merged 3 commits into from
Jun 20, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 13, 2023 •
edited
Loading

cudf is not actually used anywhere in tests, only in a single notebook. Similarly, dask is only used by legate tests

@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 13, 2023
@vyasr vyasr requested a review from bdice June 13, 2023 19:59
@vyasr vyasr self-assigned this Jun 13, 2023
bdice
bdice requested changes Jun 13, 2023
View reviewed changes
dependencies.yaml Outdated Show resolved Hide resolved
dependencies.yaml Show resolved Hide resolved
bdice
bdice reviewed Jun 13, 2023
View reviewed changes
python/pyproject.toml Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from bdice June 13, 2023 20:09
@vyasr vyasr changed the title Remove cudf from unnecessary dependency lists Clean up dependency lists Jun 13, 2023
bdice
bdice reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small suggestions.

dependencies.yaml Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from a team as a code owner June 20, 2023 14:47
@vyasr vyasr requested a review from a team June 20, 2023 14:47
@vyasr vyasr requested a review from a team as a code owner June 20, 2023 14:47
@vyasr vyasr requested a review from bdice June 20, 2023 14:48
@bdice
Copy link
Contributor

bdice commented Jun 20, 2023

LGTM. I’ll merge to unblock #224.

@bdice
Copy link
Contributor

bdice commented Jun 20, 2023

/merge

@bdice
Copy link
Contributor

bdice commented Jun 20, 2023 •
edited
Loading

Just kidding. Now I see we need several reviews first.

wence-
wence- approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vyasr
Copy link
Contributor Author

vyasr commented Jun 20, 2023

We need @jakirkham to re-approve (or @madsbk to approve) on behalf of legate codeowners before this will merge, now.

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 2cc13de into rapidsai:branch-23.08 Jun 20, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

@jakirkham jakirkham mentioned this pull request Jun 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@raydouglass raydouglass raydouglass approved these changes

@jakirkham jakirkham jakirkham approved these changes

@wence- wence- wence- approved these changes

Assignees

@vyasr vyasr

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vyasr @bdice @jakirkham @wence- @raydouglass