Fix several issues with wheel builds #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KyleFromNVIDIA
commented
Aug 16, 2024
KyleFromNVIDIA
commented
- Ensure correct directory layout in both wheels
- Add CMake entry point to libkvikio wheel
- Require kvikio wheel to use libkvikio wheel
- Exclude unneeded source files from wheel
* Ensure correct directory layout in both wheels * Add CMake entry point to libkvikio wheel * Require kvikio wheel to use libkvikio wheel * Exclude unneeded source files from wheel
KyleFromNVIDIA
added
bug
KyleFromNVIDIA
commented
Aug 16, 2024
jameslamb
approved these changes
Aug 16, 2024
|
cc @msarahan |
robertmaynard
approved these changes
Aug 16, 2024
vyasr
reviewed
Aug 16, 2024
vyasr
approved these changes
Aug 16, 2024
|
/merge |
This was referenced Sep 23, 2024
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
As of #439 the `FIND_KVIKIO_CPP` variable is largely superfluous. In principle we could still choose to support users who want to build the Python package without having the C++ library already available somewhere, but that use case is vanishingly small now that we have C++ wheels and it would require the developer to intentionally build without isolation and omit the C++ wheel from the environment. For advanced use cases like that it is reasonable to ask the user to handle building the C++ library separately on their own and making it available for the Python package to find. None of the normal build cases that we support (conda, pip, devcontainers, DLFW) require this any longer. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) URL: #466
vyasr
added a commit
to rapidsai/devcontainers
that referenced
this pull request
Sep 23, 2024
There have been a number of changes to RAPIDS builds over the course of this release and not all changes were fully propagated to the devcontainers repo. This repo addresses the following: - As of rapidsai/kvikio#369, kvikio produces wheels, and rapidsai/kvikio#439 contains critical fixes that allow the kvikio Python wheel to use the C++ libkvikio wheel. In RAPIDS Python builds we have consistently removed support for the Python build triggering the C++ build as we have created C++ wheels since in both conda and pip environments we now expect the library to be found and we do not need to automatically support the more esoteric use case of someone turning off build isolation but not having the C++ library available (devs can handle this case themselves if they wish). As a result, once rapidsai/kvikio#466 is merged, the `FIND_KVIKIO_CPP` variable will be completely superfluous and we can remove that here. - As of rapidsai/cudf#16640 libcudf no longer links to libarrow and `USE_LIBARROW_FROM_PYARROW` is no longer used. - The libcudf and libcuspatial Python package builds in the devcontainer should (like all other Python packages) omit the CUDA version suffix. For that, they need to use the `rapids_build_backend_args`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.