Fix for the one pool scheme #170
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates code for 24.09 compatibility based on Jacobs start. Additional/larger changes: * legate::cuda::StreamPool::get_stream_pool().get_stream(); is deprecated so use context.get_task_stream() and rewire things as needed. * We are always including the label/experimental channel. * The `install_info.py` file generation seem slightly different, so the test scripts now move into the test folder and then run the tests. (This could maybe be improved.) This has no effect locally, though. Signed-off-by: Sebastian Berg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to
legate_library.ccandmapper.ccto make them compatible with the new one pool scheme. Those changes are sufficient for functional correctness but not for high performance, for which one must put in more accurate pool sizes.@seberg @RAMitchell this PR is built on #163, so we can ignore all but the changes to the two files.