Update to use Rapids 24.10 at runtime and build setup #8
Conversation
This bumps all versions to 24.08 and changes the build setup that is now scikit-build-core based. Signed-off-by: Sebastian Berg <[email protected]>
New cudf joins also take a stream argument, so pass it. Signed-off-by: Sebastian Berg <[email protected]>
Signed-off-by: Sebastian Berg <[email protected]>
Signed-off-by: Sebastian Berg <[email protected]>
Signed-off-by: Sebastian Berg <[email protected]>
Signed-off-by: Sebastian Berg <[email protected]>
| @@ -89,7 +89,7 @@ test: | |||
| # import tests at build time do not work for the CUDA packages, | |||
| # because builds happen on machines without a GPU. So no tests. | |||
| commands: | |||
| - pip show legate-dataframe | |||
| - pip show legate-dataframe-cu12 | |||
There was a problem hiding this comment.
This -cu{11,12} convention shouldn't be used for conda packages, since conda has a better solution for differentiating between CUDA versions (the __cuda virtual package).
To prevent these suffixes from making it into conda packages, across RAPIDS we pass this to pip install in conda builds:
--config-settings rapidsai.disable-cuda=true
Example from cudf: https://github.com/rapidsai/cudf/blob/1b82963df736f3ad71b003443a4de1414f3ce2e5/build.sh#L78
I recommend doing the same here.
dependencies.yaml
Outdated
| common: | ||
| - output_types: [conda, requirements, pyproject] | ||
| packages: | ||
| - rapids-build-backend>=0.3.0,<0.4.0.dev0 |
There was a problem hiding this comment.
| - rapids-build-backend>=0.3.0,<0.4.0.dev0 | |
| - rapids-build-backend>=0.3.2,<0.4.0.dev0 |
Since this support is being added brand-new here, and since this project's build tool dependencies don't affect any other RAPIDS projects, I recommend going all the way to the latest version (0.3.2))
| - python | ||
| - pip |
There was a problem hiding this comment.
I think you still need pip as a host dependency, because the build ends up invoking it:
Line 158 in dd9bc3c
From the logs (link) it looks like you're still getting it, but maybe only transitively as a dependency of something else. It'd be better to specify it explicitly, to prevent surprises from that changing in the future (as recently happened to some projects with setuptools, e.g. rapidsai/dependency-file-generator#113 (comment)).
Signed-off-by: Sebastian Berg <[email protected]>
Legate has auto-configure now and LEGATE_CONFIG or the legate must be used. This was always ignored, and I am not sure that the return value was used (or an exception was raised anyway). Now, an exception should be raised, which should be OK everywhere. Signed-off-by: Sebastian Berg <[email protected]>
|
OK, compatible legate packages are available now, so things are passing. The last commit just fixes to use |
The main change here is the build setup @jameslamb.
The
pylibcudfchanges were started by Matt before, the C change, is just a very simple change in public API (there is the new stream parameter).Draft, since the update to 25.01.00.dev should happen firstReady for review, but I suspect tests will fail due to a small (fixed!) legate issue for another day.