Drop support for NetworkX 3.0 and 3.1 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriknw
added a commit
to eriknw/cugraph
that referenced
this pull request
Nov 15, 2024
This updates docs. Code changes are here: rapidsai/nx-cugraph#27
|
Docs are also updated in rapidsai/cugraph#4766 |
rlratzel
approved these changes
Nov 19, 2024
raydouglass
approved these changes
Nov 20, 2024
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Nov 25, 2024
This updates docs. Code changes are here: rapidsai/nx-cugraph#27 See: #4760 Authors: - Erik Welch (https://github.com/eriknw) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #4766
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I successfully ran tests locally for networkx versions 3.3, 3.4, 3.4.1, and 3.4.2. I'm seeing failures for 3.2 and 3.2.1, but these failures are not introduced by this PR. I'll investigate further, but getting these to pass are probably "nice to have" for this release.
We should consider adding tests (perhaps nightly tests) to test against different networkx versions, such as minimum supported version and dev versions.
Closes rapidsai/cugraph#4760