Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] remove references to setup.py in docs #36

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

jameslamb
Copy link
Member

Proposes removing references to setup.py in this project's docs. This project doesn't use a setup.py file.

How I tested this

On a machine with a couple V100s, ran the following (based on what I see in this project's CI):

docker run \
    --rm \
    --gpus all \
    -v $(pwd):/usr/local/pynvjitlink \
    -w /usr/local/pynvjitlink \
    -it rapidsai/ci-wheel:cuda12.0.1-centos7-py3.9 \
    bash

# installed CTK following this:
# https://github.com/rapidsai/pynvjitlink/blob/56a6d74f365c3e601a503dfd6a58ad4e3fc532c7/ci/build_wheel.sh
yum update -y
yum install -y \
    cuda-toolkit-12-3 \
    epel-release \
    nvidia-driver-latest-dkms

# skipped using sccache, just to avoid having to set up credentials
unset \
    CMAKE_C_COMPILER_LAUNCHER \
    CMAKE_CUDA_COMPILER_LAUNCHER \
    CMAKE_CXX_COMPILER_LAUNCHER

# built a wheel and installed it
python -m pip install -e .

# tested
make -C ./test_binary_generation
pip install pytest
pytest -v ./pynvjitlink/tests

I saw that build succeed and all tests pass.

Notes for Reviewers

In case you're wondering "what is this random contribution"... I recently joined NVIDIA and am working on RAPIDS packaging stuff. Was just poking around this repo and noticed in this in the README.

Thanks for your time and consideration.

@bdice bdice merged commit 2e7e967 into rapidsai:main Jan 5, 2024
18 checks passed
@jameslamb jameslamb deleted the docs/no-setup-py branch January 5, 2024 21:31
@jakirkham jakirkham mentioned this pull request Jan 12, 2024
jakirkham added a commit that referenced this pull request Jan 13, 2024
* Add Conda packages and CI workflows (#33)
* Set pipefail in wheel build scripts (#34)
* [REVIEW] remove references to setup.py in docs (#36)
* Update README.md (#37)
* Remove usages of rapids-env-update (#41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants