Make ucx linkage explicit and add a new CMake target for it #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
improvement
|
rerun tests |
|
Thanks for fixing this, @vyasr. Now we just need to add ucx as an explicit link dependency of cuml and cugraph |
Done. |
Merged
vyasr
changed the title
|
@robertmaynard this adds a new optional component for |
cjnolet
approved these changes
Nov 18, 2022
|
@gpucibot merge |
1 similar comment
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
This is a follow-up to #1032 to include NCCL in raft::distributed so that all communications libraries are now cleanly encapsulated in a single interface dependency, allowing us to remove it from the raft-dask Python build and simplifying the process for other consumers. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Corey J. Nolet (https://github.com/cjnolet) URL: #1077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dlopen logic for libucp in ucp_helper.hpp in favor of calling the relevant APIs directly. It also adds a new CMake component
raft::distributedthat can be used by dependent libraries to indicate the dependency on parts of raft that require UCX.While it does not change any public APIs, I have marked this PR as breaking since it does mean that any C++ code linking to UCX must now ensure that UCX is available at link time. It is no longer sufficient to make the library available at runtime.
Resolves #1031.