Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minkowki compile times #1230

Conversation

ahendriksen
Copy link
Contributor

No description provided.

@ahendriksen ahendriksen changed the base branch from branch-23.02 to branch-23.04 February 2, 2023 19:16
@ahendriksen ahendriksen force-pushed the fix-minkowki-compile-times branch from 3e93c1f to e3dd26f Compare February 2, 2023 19:18
@ahendriksen ahendriksen force-pushed the fix-minkowki-compile-times branch from e3dd26f to 082d600 Compare February 2, 2023 19:20
@ahendriksen
Copy link
Contributor Author

@cjnolet @benfred : This is definitely not passing label and style checker. Feel free to edit this PR.

@benfred benfred added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 2, 2023
@cjnolet
Copy link
Member

cjnolet commented Feb 3, 2023

Im starting to wonder if it just makes sense to remove the uint32 indexed specialization altogether (and not use it anywhere). That seems to be the one bloating the build from what I can tell.

@ahendriksen
Copy link
Contributor Author

Closing in favor of #1254

@ahendriksen ahendriksen closed this Feb 7, 2023
@ahendriksen ahendriksen deleted the fix-minkowki-compile-times branch March 17, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Time Improvement cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants