Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add brute force KNN #126

Merged
merged 14 commits into from
Feb 2, 2021
Merged

[REVIEW] Add brute force KNN #126

merged 14 commits into from
Feb 2, 2021

Conversation

hlinsen
Copy link
Contributor

@hlinsen hlinsen commented Jan 27, 2021

This PR moves cuML's brute force knn implementation to RAFT.

@hlinsen hlinsen mentioned this pull request Jan 27, 2021
Merged
@cjnolet cjnolet self-requested a review January 27, 2021 23:03
dantegd
dantegd previously requested changes Jan 27, 2021
View reviewed changes
build.sh Show resolved Hide resolved
@dantegd dantegd dismissed their stale review January 27, 2021 23:56

Wrong comment

cjnolet
cjnolet requested changes Feb 1, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far. Also tagging @lowener since he's been working in this area of the code recently.

cpp/include/raft/spatial/knn/detail/brute_force_knn.hpp Show resolved Hide resolved
cpp/include/raft/spatial/knn/detail/processing.hpp Outdated Show resolved Hide resolved
@cjnolet cjnolet added enhancement New feature or request non-breaking Non-breaking change 4 - Waiting on Author Waiting for author to respond to review improvement Improvement / enhancement to an existing function labels Feb 1, 2021
@cjnolet
Copy link
Member

cjnolet commented Feb 2, 2021

rerun tests

cjnolet
cjnolet approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet cjnolet merged commit b5d5044 into rapidsai:branch-0.18 Feb 2, 2021
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Feb 11, 2021
@hlinsen
Add SG TSP (#1360)
2743020 
This PR implements an approximated solution to the Traveling Salesperson Problem (TSP).
The algorithm is exposed under ```traversal``` through a Python API taking 2D pos as input and returning a route.
This PR relies on RAFT KNN: rapidsai/raft#126
Solves: #1185

Authors:
  - Hugo Linsenmaier (@hlinsen)

Approvers:
  - AJ Schmidt (@ajschmidt8)
  - Brad Rees (@BradReesWork)
  - Rick Ratzel (@rlratzel)
  - Alex Fender (@afender)
  - Andrei Schaffer (@aschaffer)

URL: #1360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd left review comments

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Author Waiting for author to respond to review enhancement New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hlinsen @cjnolet @dantegd