fix ivf_pq n_probes #1456
Merged
fix ivf_pq n_probes #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ivf-pq search code was including a guard like ```auto n_probes = std::min<uint32_t>(params.n_probes, index.n_lists());``` to check to make sure that we weren't selecting more values than are available. However, this wasn't being used and instead just `params.n_probes` was being passed to functions like `select_k`. This lead to asking select_k to select say 100 items, when there were only 90 to choose from - and caused some issues downstream when trying to update the select_k algorithm Fix.
lowener
approved these changes
Apr 22, 2023
|
/merge |
ahendriksen
pushed a commit
to ahendriksen/raft
that referenced
this pull request
Apr 27, 2023
The ivf-pq search code was including a guard like ```auto n_probes = std::min<uint32_t>(params.n_probes, index.n_lists());``` to check to make sure that we weren't selecting more values than are available. However, this wasn't being used and instead just `params.n_probes` was being passed to functions like `select_k`. This lead to asking select_k to select say 100 items, when there were only 90 to choose from - and caused some issues downstream when trying to update the select_k algorithm Fix. Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Micka (https://github.com/lowener) - Tamas Bela Feher (https://github.com/tfeher) URL: rapidsai#1456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ivf-pq search code was including a guard like
auto n_probes = std::min<uint32_t>(params.n_probes, index.n_lists());to check to make sure that we weren't selecting more values than are available. However,
this wasn't being used and instead just
params.n_probeswas being passed to functionslike
select_k. This lead to asking select_k to select say 100 items, when therewere only 90 to choose from - and caused some issues downstream when trying to update
the select_k algorithm
Fix.