Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update version and pinnings for 23.08. #1556

Merged
merged 10 commits into from
Jun 1, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 30, 2023

This PR fixes some outdated pinnings in branch-23.08 and applies some fixes to update-version.sh.

See also:
rapidsai/cuml#5440
#1554 (comment)

@raydouglass raydouglass added bug Something isn't working non-breaking Non-breaking change labels May 30, 2023
@bdice
Copy link
Contributor Author

bdice commented May 30, 2023

FYI @ajschmidt8 @raydouglass I caught a bug in 461e478. If YAML anchors are used, cases like - &rmm rmm==23.06 don't match /- ${DEP}==/. I used /-.* ${DEP}==/ instead. The preceding space ensures (for example) that cudf replacements don't touch dask-cudf.

@bdice bdice requested a review from a team as a code owner May 31, 2023 23:15
@bdice
Copy link
Contributor Author

bdice commented May 31, 2023

I merged #1562 into this PR to fix the build issues. Thanks @vyasr @divyegala for your help!

@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 9d0f59c into rapidsai:branch-23.08 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci CMake cpp non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants