Add index class for brute_force knn #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an index class to match the ANN methods. This allows us to precompute norms for the dataset in `brute_force::build` and then use them in `brute_force::search` - meaning we don't have to compute norms for the entire dataset on every query.
benfred
added
improvement
cjnolet
requested changes
Sep 26, 2023
| */ | ||
| template <typename T, | ||
| typename Accessor = | ||
| host_device_accessor<std::experimental::default_accessor<T>, memory_type::host>> |
There was a problem hiding this comment.
I suspect defaulting this is going to cause some unexpected behaviors down the line. We should probably not default this. Though it is great to see that we can now support datasets on host!
| raft::linalg::NormType::L2Norm, | ||
| raft::linalg::Apply::ALONG_ROWS); | ||
| } | ||
| ret.update_norms(std::move(norms)); |
There was a problem hiding this comment.
To reduce the amount of mutability, can we just accept these in the constructor as a std::optional?
Most users are going to be using raft::neighbors::brute_force::build() to construct the index instead of constructing it directly, so it doesn't really impose any additional burden on the user.
| @@ -38,6 +39,21 @@ inline void knn_merge_parts( | |||
| size_t n_samples, | |||
| std::optional<raft::device_vector_view<idx_t, idx_t>> translations = std::nullopt) RAFT_EXPLICIT; | |||
|
|
|||
| template <typename T, | |||
| typename Accessor = | |||
| host_device_accessor<std::experimental::default_accessor<T>, memory_type::host>> | |||
There was a problem hiding this comment.
Can we just let the tile get inferred? I don't think we want to default this.
|
/merge |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an index class to match the ANN methods. This allows us to precompute norms for the dataset in
brute_force::buildand then use them inbrute_force::search- meaning we don't have to compute norms for the entire dataset on every query.