Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coding of RAPIDS version where possible #2219

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Remove hard-coding of RAPIDS version where possible #2219

merged 2 commits into from
Mar 12, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Mar 7, 2024 •
edited by bdice
Loading

  • Read VERSION file from CMake
  • Read pylibraft.__version__ from docs build
  • Read VERSION file from shell scripts
  • Use environment variable substitution in Doxygen
  • Remove updates from ci/release/update-version.sh

Issue: rapidsai/build-planning#15

@KyleFromNVIDIA KyleFromNVIDIA added 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 2 - In Progress Currenty a work in progress labels Mar 7, 2024
@KyleFromNVIDIA KyleFromNVIDIA added 3 - Ready for Review and removed 5 - DO NOT MERGE Hold off on merging; see PR for details 2 - In Progress Currenty a work in progress labels Mar 7, 2024
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review March 8, 2024 14:38
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners March 8, 2024 14:38
@bdice
Copy link
Contributor

bdice commented Mar 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit 3b887cb into rapidsai:branch-24.04 Mar 12, 2024
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@divyegala divyegala divyegala approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review ci CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KyleFromNVIDIA @bdice @divyegala @AyodeAwe