[REVIEW] Replace RAFT device::buffer adapter with RMM device_uvector
#283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
added
breaking
divyegala
requested changes
Jul 1, 2021
There was a problem hiding this comment.
This may be a little pedantic, but I think we should use rmm::device_scalar for 1-sized vectors. I also see a pattern of using cudaMemsetAsync to set values for this scalars, and this wrapper has set_value_async and set_value_to_zero_async methods which will simplify the code a bit
divyegala
approved these changes
Jul 2, 2021
ChuckHastings
approved these changes
Jul 20, 2021
cjnolet
approved these changes
Jul 20, 2021
viclafargue
added a commit
to viclafargue/raft
that referenced
this pull request
Aug 16, 2021
|
Unnecessary following the merge of #286, that includes the changes. |
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Aug 27, 2021
This PR apply modifications to the cuGraph codebase to account for changes in RAFT and RMM : - rapidsai/raft#283 - rapidsai/raft#285 - rapidsai/raft#286 - rapidsai/rmm#816 This PR requires some changes in the cuHornet dependency : rapidsai/cuhornet#52 Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Brad Rees (https://github.com/BradReesWork) - AJ Schmidt (https://github.com/ajschmidt8) - Seunghwa Kang (https://github.com/seunghwak) - Chuck Hastings (https://github.com/ChuckHastings) URL: #1707
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Aug 30, 2021
This PR apply modifications to the cuML codebase to account for changes in RAFT and RMM : - rapidsai/raft#283 - rapidsai/raft#285 - rapidsai/raft#286 - rapidsai/rmm#816 Authors: - Victor Lafargue (https://github.com/viclafargue) - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) - Micka (https://github.com/lowener) - Dante Gama Dessavre (https://github.com/dantegd) - Divye Gala (https://github.com/divyegala) URL: #4077
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This PR apply modifications to the cuML codebase to account for changes in RAFT and RMM : - rapidsai/raft#283 - rapidsai/raft#285 - rapidsai/raft#286 - rapidsai/rmm#816 Authors: - Victor Lafargue (https://github.com/viclafargue) - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) - Micka (https://github.com/lowener) - Dante Gama Dessavre (https://github.com/dantegd) - Divye Gala (https://github.com/divyegala) URL: rapidsai#4077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to planned changes described in #97.
It replaces references to RAFT's
raft::mr::device::bufferinto its RMM equivalent :rmm::device_uvectorin the RAFT codebase. Removing theraft::mrnamespace would only be possible once all references to it are removed from RAFT and other libraries using it.