Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdspanifying weighted_mean and add raft::stats tests #910

Merged
merged 2 commits into from
Oct 13, 2022
Merged

mdspanifying weighted_mean and add raft::stats tests #910

merged 2 commits into from
Oct 13, 2022

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Oct 10, 2022 •
edited
Loading

Closes #880

@lowener lowener requested review from a team as code owners October 10, 2022 15:27
@lowener lowener added 3 - Ready for Review feature request New feature or request non-breaking Non-breaking change labels Oct 10, 2022
cjnolet
cjnolet approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great, @lowener. Thanks!

@cjnolet
Copy link
Member

cjnolet commented Oct 13, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ea9a50b into rapidsai:branch-22.12 Oct 13, 2022
@lowener lowener deleted the 22.12-stats-tests branch October 13, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review CMake cpp feature request New feature or request non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] raft::stats function need additional gtests
3 participants
@lowener @cjnolet @robertmaynard