Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Make dependency tracking aware of COMPONENTS #228

Closed
dantegd opened this issue Jul 29, 2022 · 0 comments · Fixed by #234
Closed

[FEA] Make dependency tracking aware of COMPONENTS #228

dantegd opened this issue Jul 29, 2022 · 0 comments · Fixed by #234
Labels
2 - In Progress Currenty a work in progress feature request New feature or request

Comments

@dantegd
Copy link
Member

dantegd commented Jul 29, 2022

Is your feature request related to a problem? Please describe.
Dependency tracking, i.e. exporting targets for consumption of libraries, currently is not aware of the components functionality. This makes it so that consumers need to call additional find_packages for finding/defining the component targets.

This came up in rapidsai/cuml#4818, where cuML uses the nn and distance components of RAFT, but if a consumer calls find cuML but no find RAFT is called then this happens:

CMake Error at /home/ursa/miniconda3/envs/skbuild4/lib/cmake/cuml/cuml-targets.cmake:56 (set_target_properties):
  The link interface of target "cuml::cuml++" contains:

    raft::nn

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  /home/ursa/miniconda3/envs/skbuild4/lib/cmake/cuml/cuml-config.cmake:77 (include)
  CMakeLists.txt:68 (find_package)

which makes it necessary to call a find RAFT in addition to find cuML.

@dantegd dantegd added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jul 29, 2022
@robertmaynard robertmaynard added 1 - On Deck To be worked on next and removed ? - Needs Triage Need team to review and classify labels Aug 1, 2022
@robertmaynard robertmaynard added 2 - In Progress Currenty a work in progress and removed 1 - On Deck To be worked on next labels Aug 15, 2022
@rapids-bot rapids-bot bot closed this as completed in #234 Sep 6, 2022
rapids-bot bot pushed a commit that referenced this issue Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currenty a work in progress feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants