Add deprecation notice to passing "" to CMAKE_CUDA_ARCHITECTURES #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
robertmaynard
force-pushed
the
deprecate_CUDA_ARCH_empty_string
branch
from
9d1581d to
a1f13fe
Compare
robertmaynard
force-pushed
the
deprecate_CUDA_ARCH_empty_string
branch
from
a1f13fe to
09e2690
Compare
bdice
approved these changes
Jan 23, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate usage of
CMAKE_CUDA_ARCHITECTURES=""in preference ofCMAKE_CUDA_ARCHITECTURES=NATIVEwhich is significantly more clear on intention.Checklist
cmake-format.jsonis up to date with these changes.