add rapids-dependency-file-generator pre-commit hook #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/shared-workflows#46.
Proposes adding a pre-commit hook to run
rapids-dependency-file-generator
.With that change, local
pre-commit
and CI will raise an error if changes todependencies.yaml
cause some error fromrapids-dependency-file-generator
.If this project checks any files modified by that tool into source control in the future, it'd also raise an error if any of those files change.
This is a bit cheaper way to find out about things like typos, misaligning spacing, etc. than waiting for CI to report it. It's very fast, shouldn't be noticeable in day-to-day development.
How I tested this
Changed an
output: conda
tooutput: condafile
(not a valid output type) independencies.yaml
.Ran
pre-commit run --all-files
.Observed the expected failure.
Reverted that change, ran
pre-commit run --all-files
again, saw everything pass.Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)